🤖 fix: clamp right sidebar width to prevent overflow#2147
Open
🤖 fix: clamp right sidebar width to prevent overflow#2147
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2a6ab978f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c2c9401 to
3330efb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents the workspace view from overflowing horizontally (and showing a bottom scrollbar) when the right sidebar is resized or the app window is narrowed.
Background
WorkspaceShellallows horizontal scrolling (overflow-x-auto). WithChatPanehaving a desktop minimum width (min-w-96= 384px) and the right sidebar using a fixed pixel width, resizing could make the combined widths exceed the available container width.Implementation
min(ABS_MAX, max(MIN, containerWidth - chatMinWidth)).useResizeObserver()on theWorkspaceShellroot element.maxWidth: "100%"to the right sidebar container so a persisted width can’t overflow narrow/stacked layouts.Validation
make static-checkRisks
Low-to-moderate: affects workspace layout sizing. The clamp has a safe fallback when container width is unknown.
Generated with
mux• Model:openai:gpt-5.2• Thinking:xhigh• Cost:$5.34