Fix positron app button so it shows in coder#692
Conversation
Update some old references to Cursor. Use new VS Code Desktop variable names. Use Positron icon from Github because Coder doesn't have one built in.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 559367ce9f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| coder_app_display_name = var.display_name | ||
| coder_app_order = var.order | ||
| coder_app_group = var.group | ||
| web_app_icon = "https://github.com/posit-dev/positron/raw/4b8cc97a7a7a9468c02cd5ac0ee685192030825d/src/vs/workbench/browser/media/positron-icon.svg" |
There was a problem hiding this comment.
The module now hardcodes web_app_icon to a GitHub raw URL. In air‑gapped deployments or environments where GitHub is blocked, the Coder app icon will fail to load because the browser cannot fetch the external asset. This repo’s AGENTS.md also notes “URLs must be relative, not absolute,” which suggests validation/standards expect local assets. Consider adding the icon to the repo (e.g., .icons/) and referencing a relative /icon/... path instead to avoid a runtime dependency on GitHub.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@geniass, can you address this, please? Otherwise LGTM. Will review again.
2 participants
Update some old references to Cursor.
Use new VS Code Desktop variable names.
Use Positron icon from Github because Coder doesn't have one built in.
Description
Type of Change