minifix(code editor): column 0 in decorators#1291
Open
ldirer wants to merge 2 commits intocodesandbox:mainfrom
Open
minifix(code editor): column 0 in decorators#1291ldirer wants to merge 2 commits intocodesandbox:mainfrom
ldirer wants to merge 2 commits intocodesandbox:mainfrom
Conversation
CodeMirror expects ranges to be sorted by 'from'
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
@ldirer is attempting to deploy a commit to the CodeSandbox Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this pull request introduce?
Fix handling of
columnStart: 0in decorators.Without this change, using
columnStart: 0always results in the entire line being part of the range (ex: the entire line is highlighted).The second commit is for the same issue as #383.
Checklist
Did not find relevant tests to add to.