Skip to content

feat(api): add Team and Domain endpoints#6

Merged
NautiluX merged 4 commits intomainfrom
client-team-domain
Apr 15, 2025
Merged

feat(api): add Team and Domain endpoints#6
NautiluX merged 4 commits intomainfrom
client-team-domain

Conversation

@schrodit
Copy link
Member

No description provided.

@schrodit schrodit requested a review from NautiluX April 11, 2025 15:16
@schrodit schrodit self-assigned this Apr 11, 2025
@schrodit schrodit requested a review from a team as a code owner April 11, 2025 15:16
Copy link
Contributor

@RiRa12621 RiRa12621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
indentation remarks are nits, up to you if you want to change those.
Generally I like small comments on function/methods to give a brief explainer on what's supposed to happen, but up to project maintainer and expected standards, so not blocking on this.

@RiRa12621
Copy link
Contributor

out of curiosity: why are we taking the int32 values and making them float32. As in, I do understand that's what we get in the generated openAPI spec, but why is that? teamIDs should never be able to become floats, no? is that something should change in the spec/our actual API or is that on purpose?

Copy link
Member

@NautiluX NautiluX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of minor comments

@schrodit
Copy link
Member Author

out of curiosity: why are we taking the int32 values and making them float32. As in, I do understand that's what we get in the generated openAPI spec, but why is that? teamIDs should never be able to become floats, no? is that something should change in the spec/our actual API or is that on purpose?

currently a bug in our api spec: https://app.clickup.com/t/8698m7zq1

Will add a comment that this is a workaround until the openapispec is fixed

@schrodit schrodit requested a review from NautiluX April 15, 2025 07:59
Copy link
Member

@NautiluX NautiluX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NautiluX NautiluX force-pushed the client-team-domain branch from 71ccb9a to 97b39ff Compare April 15, 2025 13:27
@NautiluX NautiluX merged commit 2cc3480 into main Apr 15, 2025
2 checks passed
@NautiluX NautiluX deleted the client-team-domain branch April 15, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants