Skip to content

refactor bootstrap gcp#166

Merged
siherrmann merged 17 commits intomainfrom
bootstrap-gcp-refac
Jan 30, 2026
Merged

refactor bootstrap gcp#166
siherrmann merged 17 commits intomainfrom
bootstrap-gcp-refac

Conversation

@siherrmann
Copy link
Member

@siherrmann siherrmann requested a review from Copilot January 29, 2026 12:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the GCP bootstrap functionality by reorganizing code into separate packages and introducing improved abstractions for better testability and maintainability.

Changes:

  • Moved GCP-specific bootstrap code from internal/bootstrap/gcp.go to a dedicated internal/bootstrap/gcp package
  • Extracted GCP client functionality into a separate interface and implementation
  • Refactored node management to use an interface-based approach for better testability
  • Added utility functions for string truncation and path expansion
  • Introduced a step logger for better user feedback during bootstrap operations

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
internal/util/string.go Added string truncation utility function
internal/util/path.go Added path expansion utility for handling tilde in paths
internal/installer/node/node.go Refactored Node to use interface pattern and encapsulate jumpbox logic
internal/installer/node/mocks.go Generated mock implementations for NodeManager interface
internal/installer/config_manager_profile.go Removed profile application log statements
internal/bootstrap/ovh/ovh.go Added stub for OVH bootstrapper
internal/bootstrap/gcp_client.go Deleted - moved to gcp package
internal/bootstrap/gcp/mocks.go Generated mock implementations for GCPClientManager interface
internal/bootstrap/gcp/gcp_client.go Moved GCP client implementation to gcp package with improved structure
internal/bootstrap/gcp/gcp.go Moved GCP bootstrapper implementation to gcp package
internal/bootstrap/gcp/bootstrap_suite_test.go Added test suite setup for gcp package
internal/bootstrap/gcp.go Deleted - moved to gcp package
internal/bootstrap/bootstrap_stepper.go Added step logger for user-friendly progress indication
cli/cmd/bootstrap_gcp.go Updated to use new gcp package structure
.mockery.yml Added mock generation configuration for new interfaces

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@siherrmann siherrmann requested a review from NautiluX January 29, 2026 12:41
@siherrmann siherrmann merged commit 757740c into main Jan 30, 2026
6 checks passed
@siherrmann siherrmann deleted the bootstrap-gcp-refac branch January 30, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants