Conversation
4cd76de to
5e815f3
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for direct image access from GitHub Container Registry when a Personal Access Token (PAT) is provided, enabling more efficient bootstrapping of test infrastructure by pulling container images directly instead of bundling them in installation packages.
Changes:
- Added GitHub registry type support with PAT-based authentication
- Modified VM disk sizes to be smaller (50GB vs 200GB) when using direct GitHub access
- Updated installer to use lite packages when GitHub PAT is configured
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/bootstrap/gcp/gcp.go | Added GitHub registry type constant, PAT/user fields, GitHub access configuration method, and conditional logic for package selection and disk sizing |
| internal/bootstrap/gcp/gcp_test.go | Refactored test setup to share mock objects across test cases and added tests for GitHub access configuration |
| cli/cmd/bootstrap_gcp.go | Added CLI flags for GitHub PAT and registry user, with validation logic |
| docs/oms-cli_beta_bootstrap-gcp.md | Updated documentation to include new GitHub PAT and registry user flags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
siherrmann
approved these changes
Feb 3, 2026
Signed-off-by: NautiluX <2600004+NautiluX@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bootstrapping test infra, allow pulling from image registry when PAT is set.
Clickup: https://app.clickup.com/t/869c079a0