feat(bootstrap-gcp): Add managed services & openbao config#197
Merged
feat(bootstrap-gcp): Add managed services & openbao config#197
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds OpenBao configuration support and hardcoded managed services (postgres, babelfish, s3) to the GCP bootstrap process. OpenBao is a secrets management solution, and this change enables users to configure it through both the interactive config generator and the GCP bootstrapper.
Changes:
- Added OpenBaoConfig struct with URI, Engine, User, and Password fields (password excluded from YAML serialization)
- Modified ManagedServiceConfig fields to be optional (except Name and Version) to support minimal service definitions
- Added hardcoded managed services configuration in GCP bootstrapper
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/installer/files/config_yaml.go | Added OpenBaoConfig struct, made ManagedServiceConfig fields optional, added secret handling for OpenBao (with duplication issue) |
| internal/installer/config_generator_collector.go | Added interactive prompts for OpenBao configuration |
| internal/bootstrap/gcp/gcp_test.go | Added test coverage for OpenBao configuration, verified nil case |
| internal/bootstrap/gcp/gcp.go | Added OpenBao fields to CodesphereEnvironment, hardcoded managed services, populated OpenBao config conditionally |
| docs/oms-cli_init_install-config.md | Added documentation for OpenBao CLI flags |
| docs/oms-cli_beta_bootstrap-gcp.md | Added documentation for OpenBao bootstrap flags |
| cli/cmd/init_install_config.go | Added CLI flags and options for OpenBao configuration |
| cli/cmd/bootstrap_gcp.go | Added OpenBao CLI flags, removed potentially sensitive log output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NautiluX
force-pushed
the
bootstrap-managed-services
branch
2 times, most recently
from
e1268f1 to
a5036ec
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NautiluX
force-pushed
the
bootstrap-managed-services
branch
2 times, most recently
from
155ca66 to
28af276
Compare
* Add openbao config * Add managed service config * Remove yaml infra output fixes CU-869c3kpk3 and CU-869c3kry4
NautiluX
force-pushed
the
bootstrap-managed-services
branch
from
55892b5 to
b6757ff
Compare
Signed-off-by: NautiluX <2600004+NautiluX@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes CU-869c3kpk3 and CU-869c3kry4