Skip to content

restructure code#2

Merged
RiRa12621 merged 7 commits intomainfrom
rrackow-restrcuture
Apr 9, 2025
Merged

restructure code#2
RiRa12621 merged 7 commits intomainfrom
rrackow-restrcuture

Conversation

@RiRa12621
Copy link

No description provided.

Copy link
Member

@NautiluX NautiluX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it really need a separate binary? Could also be just a subcommand?

@RiRa12621
Copy link
Author

I did like the idea of having them separate. Since they're in the same repo, they can easily share functions etc.
If the functionally for either gets extended, doesn't make the other more fat

@RiRa12621 RiRa12621 force-pushed the rrackow-restrcuture branch from 1e57b25 to 96631a0 Compare April 8, 2025 18:57
@RiRa12621 RiRa12621 force-pushed the rrackow-restrcuture branch from e2c7280 to 87ac244 Compare April 8, 2025 19:03
@RiRa12621
Copy link
Author

I guess we would probably also not need cobra or anything for the service? i guess it would just have a single command and flags or a config file, no sub-commnds or anything?
So while they will perform some similar actions, they will probably differ in how they're set up @NautiluX

@RiRa12621
Copy link
Author

svc build failing is expected, because there's nothin the service folder yet to be build, including the folder that doens't exist.

@NautiluX
Copy link
Member

NautiluX commented Apr 9, 2025

should we disable the action then until it's expected to work or add the necessary boilerplate to make it work?

@RiRa12621 RiRa12621 force-pushed the rrackow-restrcuture branch from 18e896d to 0da0d56 Compare April 9, 2025 10:56
@RiRa12621 RiRa12621 merged commit 5c85a18 into main Apr 9, 2025
3 checks passed
@RiRa12621 RiRa12621 deleted the rrackow-restrcuture branch April 9, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants