-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add quiet mode option for package download and update related tests #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e2472ed
feat: Add quiet mode option for package download and update related t…
OliverTrautvetter 774e70f
fix: writer assignment in DownloadBuildArtifact
OliverTrautvetter 51ba8cc
fix: Adjust WriteCounter behavior and test timing
OliverTrautvetter 54fa58a
refactor: Change WriteCounter test to use Ginkgo
OliverTrautvetter b27c3c1
fix: Improve slowReader behavior in tests
OliverTrautvetter 096671f
Merge branch 'main' into quiet-download-option
OliverTrautvetter 84f2222
Merge branch 'main' into quiet-download-option
OliverTrautvetter 378c6da
refactor(tests): remove slowReader and related sleep logic for faster…
OliverTrautvetter ee162c8
fix remove old comment
OliverTrautvetter 47bf838
Merge branch 'main' into quiet-download-option
OliverTrautvetter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // Copyright (c) Codesphere Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package portal_test | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "log" | ||
| "time" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
|
|
||
| "github.com/codesphere-cloud/oms/internal/portal" | ||
| ) | ||
|
|
||
| var _ = Describe("WriteCounter", func() { | ||
| It("emits progress logs on write", func() { | ||
| // capture log output | ||
| var logBuf bytes.Buffer | ||
| prev := log.Writer() | ||
| log.SetOutput(&logBuf) | ||
| defer log.SetOutput(prev) | ||
|
|
||
| var underlying bytes.Buffer | ||
| wc := portal.NewWriteCounter(&underlying) | ||
|
|
||
| // force an update by setting LastUpdate sufficiently in the past | ||
| wc.LastUpdate = time.Now().Add(-time.Second) | ||
|
|
||
| _, err := wc.Write([]byte("hello world")) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| out := logBuf.String() | ||
| Expect(out).NotTo(BeEmpty()) | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.