Skip to content

feat: add install codesphere command and tests#36

Merged
siherrmann merged 11 commits intomainfrom
install-codesphere
Oct 16, 2025
Merged

feat: add install codesphere command and tests#36
siherrmann merged 11 commits intomainfrom
install-codesphere

Conversation

@siherrmann
Copy link
Member

@siherrmann siherrmann commented Oct 13, 2025

@siherrmann siherrmann requested a review from Copilot October 13, 2025 11:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new install codesphere command to the CLI tool with comprehensive test coverage. The main purpose is to provide functionality for installing Codesphere instances from package files on Linux amd64 platforms.

  • Adds install codesphere subcommand with package extraction and installation logic
  • Extends FileIO interface with ReadDir method and updates mocks accordingly
  • Refactors Package struct to expose GetWorkDir method publicly

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cli/cmd/install_codesphere.go Implements new install codesphere command with extraction and installation logic
cli/cmd/install_codesphere_test.go Comprehensive test suite for the new command functionality
cli/cmd/install.go Updates install command to accept GlobalOptions and adds codesphere subcommand
cli/cmd/root.go Reorganizes command structure and adds install codesphere to command tree
internal/installer/package.go Makes getWorkDir method public (GetWorkDir) for external access
internal/util/filewriter.go Extends FileIO interface with ReadDir method
internal/util/mocks.go Adds mock implementation for new ReadDir method and reorders imports

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@siherrmann siherrmann requested a review from NautiluX October 13, 2025 12:09
Copy link
Member

@NautiluX NautiluX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! I think we need to identify a good way to test this on mac-based machines.

@NautiluX
Copy link
Member

oh, please also provide a description to the PR, at minimum linking the CU card for paper trail ;)

@siherrmann siherrmann requested a review from Copilot October 15, 2025 12:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@NautiluX NautiluX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just be aware the help output of the installation script won't be visible to users when running via OMS, so we need to make sure the descriptions explain the arguments

@siherrmann siherrmann merged commit db6caee into main Oct 16, 2025
4 checks passed
@siherrmann siherrmann deleted the install-codesphere branch October 16, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants