Open
Conversation
Contributor
Author
|
Don’t check the commits yet — I want to discuss the solution for the second part of the issue. I discovered that the odd behavior is caused by this line: When, for example, the bold tool is applied, the inline toolbar rerenders, this line executes, and the Should we remove this line? Additionally, I noticed that the inline toolbar constantly rerenders when the link element is selected. For some reason, this is caused by this line: I haven’t figured out exactly why, but changing fromvalue to defaultValue resolves the issue.
|
Member
I don't think you should simply remove this line. Firstly, find out what this line is supposed to do. I don't remember it at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Applying the link tool on top of other formatting may also remove other tools tags.
Issue:
#2890
Solution:
Refactor removeFakeBackground function so it would no longer remove text formatting.