ga4: make "set [string] [object]" requests work#46
Open
AceGentile wants to merge 1 commit intocodler:masterfrom
Open
ga4: make "set [string] [object]" requests work#46AceGentile wants to merge 1 commit intocodler:masterfrom
AceGentile wants to merge 1 commit intocodler:masterfrom
Conversation
gtag set command can have two sets of params:
```
gtag('set', <object>)
gtag('set', <string>, <object>)
```
the latter doesn't work because of some checks in set()
method requiring the first parameter to be always an object.
This breaks some user-scoped custom dimensions like this one:
```
gtag('set', 'user_properties', {
favorite_composer: 'Mahler',
favorite_instrument: 'double bass',
season_ticketholder: 'true'
});
```
rif. https://support.google.com/analytics/answer/12370404
|
When are we planning to merge this ? @codler @AceGentile |
|
This should be definitely merged |
|
Any workaround? Been a while and branch has not been merged. |
Repository owner
deleted a comment from
jpyoda
Dec 8, 2023
Repository owner
deleted a comment from
elamperti
Jan 18, 2024
Repository owner
deleted a comment from
elamperti
Jan 18, 2024
|
@codler why make a package you don't intend to maintain ? People spend their time to write code and submit PRs too. |
|
this comment is a workaround for me: #34 (comment) and can be debugged through in GA > admin > data display > debug view > user properties active now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gtag set command can have two sets of params:
the latter doesn't work because of some checks in set() method requiring the first parameter to be always an object. This breaks some user-scoped custom dimensions like this one:
This should fix #34
rif. https://support.google.com/analytics/answer/12370404