Conversation
- Tested with website_search
…sed-across-different-networks
ofrancon
previously approved these changes
Apr 17, 2025
Contributor
ofrancon
left a comment
There was a problem hiding this comment.
works for me!
Consider:
- making the tools async
- adding unit tests
…sed-across-different-networks
…sed-across-different-networks
…rt async operations.
Collaborator
Author
Changes
Tests
|
…sed-across-different-networks
…sed-across-different-networks
…sed-across-different-networks
…sed-across-different-networks
…sed-across-different-networks
…sed-across-different-networks
…sed-across-different-networks
…sed-across-different-networks
…sed-across-different-networks
…sed-across-different-networks
d1donlydfink
requested changes
Apr 25, 2025
…sed-across-different-networks
…sed-across-different-networks
- Modify docstring for RagGlobal
Noravee
commented
Apr 25, 2025
neuro_san/coded_tools/rag_global.py
Outdated
| from neuro_san.interfaces.coded_tool import CodedTool | ||
|
|
||
|
|
||
| class RagGlobal(CodedTool): |
Collaborator
Author
There was a problem hiding this comment.
Change class name to match the convention.
|
|
||
| This is useful in workflows where external search tools provide candidate links, | ||
| and RAG is applied afterward to synthesize a meaningful answer from the linked content. | ||
| """ |
Collaborator
Author
There was a problem hiding this comment.
Modify the docstring to provide more explanation.
| from neuro_san.interfaces.coded_tool import CodedTool | ||
|
|
||
|
|
||
| class WebsiteSearchGlobal(CodedTool): |
Collaborator
Author
There was a problem hiding this comment.
Change class name to match the convention
Collaborator
Author
Changes
Test
|
d1donlydfink
requested changes
Apr 25, 2025
…sed-across-different-networks
…website_rag accordingly.
Collaborator
Author
Changes
Tests
Notes
|
d1donlydfink
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests