Conversation
| azure_endpoint=self.get_value_or_env(config, "azure_endpoint", | ||
| "AZURE_OPENAI_ENDPOINT"), | ||
| deployment_name=config.get("deployment_name"), | ||
| deployment_name=self.get_value_or_env(config, "deployment_name", |
There was a problem hiding this comment.
First get the value for "deployment_name" from config file (Previous behavior). If not available, get the value from the new env variable
| "OPENAI_API_VERSION": ["validation error", "api_version", "OPENAI_API_VERSION", "Error code: 404", | ||
| "Resource not found"], | ||
| "deployment_name": ["Error code: 404", "Resource not found", "API deployment for this resource does not exist"], | ||
| "AZURE_OPENAI_DEPLOYMENT_NAME": ["Error code: 404", "Resource not found", "API deployment for this resource does not exist"], |
There was a problem hiding this comment.
We now have an env var for this.
| @@ -27,7 +27,7 @@ | |||
| "Connection error"], | |||
| "OPENAI_API_VERSION": ["validation error", "api_version", "OPENAI_API_VERSION", "Error code: 404", | |||
There was a problem hiding this comment.
@d1donlydfink there is another ticket (https://leaf-ai.atlassian.net/browse/UN-3322) to add a documentation link to the error message in this file on how to set API keys etc for Azure. I've looked at the way the error message is constructed and can't think of a non-hacky way to add this feature. Any thoughts on how to do this?
There was a problem hiding this comment.
If I understand correctly, you could break out a separate dictionary with extra text that gets included based on the env var key here that was found. If there is no entry in such a dictionary, then no extra text is added.
Sound reasonable?
…ent_name-in-AzureOpenAI
kxk302
deleted the
UN-3328-Add-environment-variable-for-deployment_name-in-AzureOpenAI
branch
2 participants
No description provided.