483-Removed gRPC test case from this list#484
Merged
vince-leaf merged 1 commit intomainfrom Oct 17, 2025
Merged
Conversation
vince-leaf
commented
Oct 17, 2025
| # Barring that, try to stick to alphabetical order. | ||
| # http has been covered by integration test | ||
| # "music_nerd_pro/combination_responses_with_history_http.hocon", | ||
| "music_nerd_pro/combination_responses_with_history_grpc.hocon", |
Contributor
Author
There was a problem hiding this comment.
Removed grpc test case
andreidenissov-cog
approved these changes
Oct 17, 2025
Contributor
andreidenissov-cog
left a comment
There was a problem hiding this comment.
Looks OK to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removed the failure test case from the nightly run smoke test.
The change below is the result of a smoke test failure currently.
Disable gRPC connectivity and gRPC service in neuro-san. #476