This repository was archived by the owner on Jun 22, 2020. It is now read-only.
Open
Conversation
04595ee to
194a1f4
Compare
Author
|
Apologies, noticed a small bug in the ionomy API. Will fix and update, please hold off merging until then. |
194a1f4 to
9e2eb43
Compare
Author
|
PR updated to reflect latest ionomy API. Ready for review/merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this Pull Request?
Add ionomy exchange.
I have added Specs
(If implementing Market Ticker) I have verified that the
volumerefers to BASE(If implementing Market Ticker) I have verified that the
baseandtargetis assigned correctlyI have implemented the
trade_page_urlmethod that links to the exchange page with thebaseandtargetpassed in. If not available, enter the root domain of the exchange website.I have verified at least ONE ticker volume matches volume shown on the trading page (use script below)