Skip to content

fix(search): provide graceful warning when a registry is offline#296

Merged
zeroshade merged 4 commits intomainfrom
graceful-search-fail
Feb 6, 2026
Merged

fix(search): provide graceful warning when a registry is offline#296
zeroshade merged 4 commits intomainfrom
graceful-search-fail

Conversation

@zeroshade
Copy link
Member

fixes #295

Changes dbc search to succeed with a warning if any of the registries still succeed and return a list of drivers while one or more fail.

If there's an error but no drivers at all then we still fail entirely.

@ianmcook
Copy link
Member

ianmcook commented Feb 6, 2026

I didn't realize it when I opened the issue, but apparently dbc install and dbc add also fail in this case. Can you solve that too?

@ianmcook
Copy link
Member

ianmcook commented Feb 6, 2026

If dbc install or dbc add finds the driver the user requests in the public registry, it shouldn't print a warning, it should just succeed.

@ianmcook
Copy link
Member

ianmcook commented Feb 6, 2026

Edge case that this doesn't handle well: if BOTH registries are unreachable, it prints both a warning and an error:
image

@zeroshade
Copy link
Member Author

@ianmcook @amoeba updated based on the comments, please check again

@zeroshade zeroshade added this to the 0.2.0 milestone Feb 6, 2026
@ianmcook
Copy link
Member

ianmcook commented Feb 6, 2026

Looks like dbc sync suffers the same issue 🙃
Can you fix that too please @zeroshade ?

@ianmcook
Copy link
Member

ianmcook commented Feb 6, 2026

And dbc info and dbc docs, too!

@zeroshade
Copy link
Member Author

@ianmcook I've updated all the subcommands appropriately. we should have all the scenarios covered now

@ianmcook
Copy link
Member

ianmcook commented Feb 6, 2026

Seems good now! Thanks @zeroshade

@zeroshade zeroshade merged commit 8a3af03 into main Feb 6, 2026
10 checks passed
@zeroshade zeroshade deleted the graceful-search-fail branch February 6, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Succeed with warning when private registry is offline

2 participants