tests: fuzz rx and tx hooks in rivian.h#2962
Closed
mpurnell1 wants to merge 2 commits intocommaai:masterfrom
Closed
tests: fuzz rx and tx hooks in rivian.h#2962mpurnell1 wants to merge 2 commits intocommaai:masterfrom
mpurnell1 wants to merge 2 commits intocommaai:masterfrom
Conversation
17 tasks
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes incremental progress towards #2944. In this PR, I utilize the helper functions added in #2952 to thoroughly test rx and tx hooks in rivian.h.
Adds coverage for the following lines (NOTE: these line numbers are what were reported by gcovr. They sometimes point to the last covered line before an uncovered branch):
Verification
opendbc/safety/tests/test.sh --report(with branch coverage enabled) on master:Overall branch coverage: 92.3%
opendbc/safety/tests/test.sh --reporton this branch:Overall branch coverage: 92.6%