Setup proper pip package (#2239)#2313
Closed
AgentsLogic wants to merge 1 commit intocommaai:masterfrom
Closed
Conversation
d91b1d4 to
a45cd5e
Compare
- Add setup.py with custom build command to optionally build firmware - Add MANIFEST.in to include firmware, certs, and headers in package - Update pyproject.toml with proper package metadata and CLI entry points - Make opendbc import optional to prevent installation failures - Add CLI entry points for panda-health, panda-flash, and panda-version - Convert script main functions to be callable from CLI entry points This allows pandacan to be installed as a standard pip package with all necessary components including firmware, certificates, and build tools.
a45cd5e to
3a8a6d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2239
Summary
This PR sets up
pandacanas a proper pip package that includes firmware, certificates, and all necessary components to fully use the panda project.Changes
panda-health,panda-flash, andpanda-versioncommandspython/__init__.pyto prevent installation failures when opendbc is not availablescripts/get_version.pyscripts/can_health.pyscripts/reflash_internal_panda.pyKey Features
pip install pandacanpanda-health- Monitor panda CAN healthpanda-flash- Flash internal pandapanda-version- Get panda versionTesting
The package should be sufficient to remove panda as a submodule from openpilot and add it as a normal Python dependency. This will be validated in a follow-up openpilot PR.
Notes