Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
- Coverage 83.84% 82.90% -0.94%
==========================================
Files 46 46
Lines 8246 8244 -2
Branches 2190 2190
==========================================
- Hits 6914 6835 -79
- Misses 855 904 +49
- Partials 477 505 +28 ☔ View full report in Codecov by Sentry. |
|
|
|
Thank you @jfennick , can you fix the test errors? |
jfennick
force-pushed
the
bump_prov_version
branch
from
ac7b05e to
74ea21b
Compare
| main_run, | ||
| PROV.wasAssociatedWith, | ||
| engine, | ||
| ) in g, "Wf run not associated with wf engine" |
There was a problem hiding this comment.
Why does this need to be removed? Maybe do a side-by-side diff of running cwltool --provenance some_folder tests/wf/sec-wf-out.cwl with this PR and without it.
There was a problem hiding this comment.
The short answer is that I couldn't get the CI to pass without removing it. Yes, I tried doing side by side diffs and/or other ways of debugging it, but I'm all out of energy. I don't think I'm going to be able to fix this particular assertion.
I suspect the change is due to one of the following two commits from the prov repo, but IDK.
trungdong/prov@a8aba63
trungdong/prov@2e19dcc
There was a problem hiding this comment.
I tried the newer prov version (2.1.1) but the tests still fail (the association is still missing) → 496ea52
2 participants
Bump the version of the
provlibrary for compatibility with the following PR:trungdong/prov#158