Fix normalization of image id for singularity pre-pulled images#2171
Open
spinto wants to merge 1 commit intocommon-workflow-language:mainfrom
Open
Fix normalization of image id for singularity pre-pulled images#2171spinto wants to merge 1 commit intocommon-workflow-language:mainfrom
spinto wants to merge 1 commit intocommon-workflow-language:mainfrom
Conversation
Member
|
What does singularity do in recent versions? If it is something different, then we'll need an apptainer specific fix |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2171 +/- ##
==========================================
- Coverage 85.18% 77.61% -7.58%
==========================================
Files 46 46
Lines 8332 8332
Branches 1954 1954
==========================================
- Hits 7098 6467 -631
- Misses 768 1346 +578
- Partials 466 519 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@mr-c I have just tested with the latest SingularityCE, and it also replaces the ':' with '_' |
Member
|
Okay, now we need to figure out which versions of singularity & apptainer have which behavior |
Apptainer will replace the ':' character with an '_'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Apptainer will replace the ':' character with an '_' when the image is pulled during pre-pull, not a '/'.
In fact, '_latest' is correctly added if a ':' is not present. I am not sure what is the reason for the '/' replacement, as '/' is not allowed at all in the docker image name+tag.
This pull fixes the replacement of the ':' character.