Skip to content

Conversation

@mr-c
Copy link
Member

@mr-c mr-c commented Oct 3, 2025

  • write more docstrings
  • Make one more Python 3.9 supporting release when the final release of Python 3.9.x happens at the end of this month (2025-10)
  • then merge this PR

@mr-c mr-c force-pushed the drop_py3.9 branch 4 times, most recently from ccb87b0 to 975bdfa Compare October 5, 2025 08:42
@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 81.72840% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.20%. Comparing base (d38605a) to head (404b2a2).
⚠️ Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
schema_salad/makedoc.py 51.28% 11 Missing and 8 partials ⚠️
schema_salad/fetcher.py 63.82% 12 Missing and 5 partials ⚠️
schema_salad/java_codegen.py 77.27% 8 Missing and 2 partials ⚠️
schema_salad/cpp_codegen.py 82.00% 5 Missing and 4 partials ⚠️
schema_salad/dotnet_codegen.py 83.33% 3 Missing and 2 partials ⚠️
schema_salad/python_codegen.py 84.84% 3 Missing and 2 partials ⚠️
schema_salad/typescript_codegen.py 83.33% 3 Missing and 2 partials ⚠️
schema_salad/dlang_codegen.py 91.17% 1 Missing and 2 partials ⚠️
schema_salad/sourceline.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   83.45%   83.20%   -0.25%     
==========================================
  Files          22       22              
  Lines        4961     4984      +23     
  Branches     1185     1192       +7     
==========================================
+ Hits         4140     4147       +7     
- Misses        544      556      +12     
- Partials      277      281       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mr-c mr-c force-pushed the drop_py3.9 branch 2 times, most recently from e842189 to 11ee025 Compare October 8, 2025 08:43
@mr-c mr-c marked this pull request as ready for review November 1, 2025 17:06
@mr-c mr-c merged commit a13c926 into main Nov 2, 2025
27 of 30 checks passed
@mr-c mr-c deleted the drop_py3.9 branch November 2, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant