Convert nearby package to kotlin

[psh]

Parent issue: #5928

I believe this converts the last remaining Java files to Kotlin in the project. Submitting as a Draft PR for now, as I know it's a little on the large size, and happy to break it into pieces for review and merging, or, convert to actual PR if you prefer.

Tested on Pixel 9 pro XL, all unit tests pass.

[nicolas-raoul]

I am not against reviewing this as a whole rather than as several pull requests, especially since this is all about Nearby.

Problem: Somehow, most pins are first red then become green. I will post a screencast from my phone.

[nicolas-raoul]

ab9f1af9-df28-4718-974c-28f4c0d93401.mp4

[nicolas-raoul]

On the opposite, on branch main, pins load to red or green and stay as such.

[psh]

Thanks for the feedback - I'll dig into that!

[nicolas-raoul]

I am getting this crash when trying to upload via Nearby:

4605b9fa-e797-401a-ada8-a09633d38517.mp4

STACK_TRACE=java.lang.NullPointerException: Attempt to invoke virtual method 'double fr.free.nrw.commons.location.LatLng.getLatitude()' on a null object reference
at fr.free.nrw.commons.nearby.presenter.NearbyParentFragmentPresenter.searchCloseToCurrentLocation(NearbyParentFragmentPresenter.kt:610)

In branch main, the same picture's metadata is loaded fine, and caption is correctly filled with the selected item's label.

Would you mind checking? 🙂

[psh]

There's an up-coming PR (#6579) that I believe addresses this same issue in the existing Java code. I'll convert this PR to draft and let you merge that Java one, and I'll re-convert the Java afterwards so that we are starting from a definite fix for an existing problem.

Dont worry - not abandoning this PR - just making space for the other once to come through and not get lost in the shuffle!

[nicolas-raoul]

Understood, I started testing pull request #6579

By any chance, would you mind reviewing its code changes? I think you are a better judge than me. :-)
Context: #6538

[github-actions]

✅ Generated APK variants!

• 🤖 Download betaDebugAPK
• 🤖 Download prodDebugAPK

[psh]

Just a quick check-in. Looks like 3 other PRs should merge ahead of this one, so keeping in draft state for now -

• fix(nearby): Prevent crash in offline search caused by null map boundaries #6579
• Fix Explore>Map description showing raw HTML tags #6595
• 👍 Refactoring NearbyParentFragmentPresenter.loadPlacesDataAsync() (Part 2) #6609 (merged)

I'm tracking their progress and will update this PR accordingly once they move forward.