Fix: state loss in SearchActivity and MediaDetailPagerFragment during screen rotation#6605
Open
Kota-Jagadeesh wants to merge 8 commits intocommons-app:mainfrom
Open
Fix: state loss in SearchActivity and MediaDetailPagerFragment during screen rotation#6605Kota-Jagadeesh wants to merge 8 commits intocommons-app:mainfrom
Kota-Jagadeesh wants to merge 8 commits intocommons-app:mainfrom
Conversation
7 tasks
| outState.putBoolean("isFeaturedImage", isFeaturedImage) | ||
| // save the current item position so it can be restored after rotation | ||
| if (binding != null) { | ||
| outState.putInt("current-page", binding!!.mediaDetailsPager.currentItem) |
Collaborator
There was a problem hiding this comment.
Just wondering: if we make binding null in onDestroy to fix memory leaks, will this always be null and never run? 🤔
What alternatives do we have?
|
✅ Generated APK variants! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
What changes did you make and why?
SearchActivity: added thaonSaveInstanceStateto track the current media position and updatedonCreateto restore the media detail view if a position was previously saved. This replaces the previous temporary fix inonResumewhich forced a back-press on rotation.MediaDetailPagerFragment: Updated the fragment to save and restore its internalViewPagercurrent item index.binding.root.postfor restoration, I ensured the UI is fully laid out before re-opening details, preventing crashes and ensuring the user stays on the same image they were viewing before rotating the device.onBackPressed()call fromonResume()which was an anti-pattern causing the fragment back-stack to increase incorrectly.Tests performed (required)
Tested ProdDebug on Redmi Note 13 Pro with API level 35.
isFeaturedImageandeditableflags are preserved after rotation, keeping menu items consistent.Part of issue #6508