Conversation
japsu
approved these changes
Mar 22, 2021
Collaborator
japsu
left a comment
There was a problem hiding this comment.
Regardless of the new failing test I added, LGTM & make a new issue about recursive data structures.
Collaborator
|
Also once this is merged, let's release 0.3.0. We've added new tags and this change may introduce subtle changes in the degree of laziness, so incrementing the minor is warranted (would probably be 2.0.0 if we were already 1.x). |
Collaborator
|
See five:
- - []
two:
- - []🤔 |
Collaborator
Author
As far as correctness goes, it should, shouldn't it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to work... Got ideas for better test cases?
Fixes #15