Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
@conda-forge/help-r, ready for review! |
danielnachun
left a comment
danielnachun
left a comment
There was a problem hiding this comment.
Since this package is only GitHub, we can't use https://github.com/bgruening/conda_r_skeleton_helper as we normally do to generate the recipe. So we can try our best to match what it would make, at least enough that our bots can manage the recipe in the future.
recipes/r-cosg/meta.yaml
Outdated
| {% set github = "genecell" %} | ||
| {% set name = "COSGR" %} | ||
|
|
||
| package: | ||
| name: r-cosg | ||
| version: {{ version }} | ||
|
|
||
| source: | ||
| url: https://github.com/{{ github }}/{{ name }}/archive/refs/tags/v{{ version }}.tar.gz |
There was a problem hiding this comment.
| {% set github = "genecell" %} | |
| {% set name = "COSGR" %} | |
| package: | |
| name: r-cosg | |
| version: {{ version }} | |
| source: | |
| url: https://github.com/{{ github }}/{{ name }}/archive/refs/tags/v{{ version }}.tar.gz | |
| package: | |
| name: r-cosg | |
| version: {{ version }} | |
| source: | |
| url: https://github.com/genecell/COSGR/archive/refs/tags/v{{ version }}.tar.gz |
Those Jinja keys are not needed and omitting them improves readability.
recipes/r-cosg/meta.yaml
Outdated
| - r-base >=4.0 | ||
| - r-data.table | ||
| - r-proxyc | ||
| - r-matrix | ||
| - r-seuratobject >=3.0.0 | ||
| run: | ||
| - r-base >=4.0 | ||
| - r-data.table | ||
| - r-proxyc | ||
| - r-matrix | ||
| - r-seuratobject >=3.0.0 |
There was a problem hiding this comment.
| - r-base >=4.0 | |
| - r-data.table | |
| - r-proxyc | |
| - r-matrix | |
| - r-seuratobject >=3.0.0 | |
| run: | |
| - r-base >=4.0 | |
| - r-data.table | |
| - r-proxyc | |
| - r-matrix | |
| - r-seuratobject >=3.0.0 | |
| - r-base | |
| - r-data.table | |
| - r-proxyc | |
| - r-matrix | |
| - r-seuratobject >=3.0.0 | |
| run: | |
| - r-base | |
| - r-data.table | |
| - r-proxyc | |
| - r-matrix | |
| - r-seuratobject >=3.0.0 |
The r-base version should not be set like this - the R versions we use are supposed to be determined by conda-forge-pinnings rather than in individual recipes.
recipes/r-cosg/meta.yaml
Outdated
| about: | ||
| home: https://github.com/genecell/COSGR | ||
| license: BSD-3-Clause | ||
| license_family: BSD |
There was a problem hiding this comment.
| license_family: BSD |
This key is deprecated and is no longer needed.
recipes/r-cosg/meta.yaml
Outdated
| build: | ||
| number: 0 | ||
| noarch: generic | ||
| script: R CMD INSTALL --build . |
There was a problem hiding this comment.
Can you please change this recipe so that instead of using script here, you use separate build.sh and bld.bat scripts like is done in this PR for example: #32161? I realize it's odd to have a bld.bat script for a noarch: generic package (it will be ignored for now), but we do this to accommodate the possibility in the future that package begins to have native code.
|
@danielnachun All four changes addressed, thanks for the review! Ready for another look. |
3 participants
Add r-cosg recipe
Package: r-cosg (COSG for R)
Homepage: https://github.com/genecell/COSGR
License: BSD-3-Clause
Description
COSG is a cosine similarity-based method for accurate and scalable marker gene identification in single-cell RNA-seq, scATAC-seq, and spatially resolved transcriptome data. This is the R implementation, compatible with Seurat v3, v4, and v5.
Checklist
noarch: generic(pure R, no compiled code)Notes
r-data.table,r-proxyc,r-matrix,r-seuratobject) are already on conda-forge