Add sagemaker-mlops, sagemaker-serve and sagemaker-train, sagemaker-schema-inference-artifacts#32176
Add sagemaker-mlops, sagemaker-serve and sagemaker-train, sagemaker-schema-inference-artifacts#32176mollyheamazon wants to merge 14 commits intoconda-forge:mainfrom
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sagemaker-train/recipe.yaml:
For recipes/sagemaker-train/recipe.yaml:
For recipes/sagemaker-serve/recipe.yaml:
For recipes/sagemaker-serve/recipe.yaml:
For recipes/sagemaker-mlops/recipe.yaml:
For recipes/sagemaker-mlops/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21919934418. Examine the logs at this URL for more detail. |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sagemaker-serve/recipe.yaml:
For recipes/sagemaker-mlops/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21921779267. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/sagemaker-schema-inference-artifacts/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21968620937. Examine the logs at this URL for more detail. |
|
Changes look good to me |
| @@ -0,0 +1,201 @@ | |||
| Apache License | |||
There was a problem hiding this comment.
There is no need to add LICENSE text files explicitly if they are already linked from the recipe, and it's already there https://github.com/aws/sagemaker-python-sdk/blob/master/LICENSE.
Same comment for other LICENSE files in this PR.
There was a problem hiding this comment.
The LICENSE file is needed in the recipe directory because:
- The PyPI source packages for
sagemaker-mlopsandsagemaker-servedon't include a LICENSE file - Conda-forge's linter requires
license_fileto be present and will fail without it - The GitHub link points to the parent repo, but these are separate PyPI distributions
Do you have suggestion for a better approach to this?
There was a problem hiding this comment.
Ah okie, didn't look inside the sdist!
I would argue to make the packages PEP 639 complaint anyway and add the license files to them.
But I would wait for someone from conda-forge-core to comment here (I can't merge this PR). Once the CI is green they can be tagged via @conda-forge/help-python ready for review! as a comment.
There was a problem hiding this comment.
I would argue to make the packages PEP 639 complaint anyway and add the license files to them.
I agree on this too. Will include them in our next pypi release.
Thanks Mridul!
|
|
||
| about: | ||
| summary: Open source library for Hugging Face Task Sample Inputs and Outputs | ||
| homepage: https://pypi.org/project/sagemaker-schema-inference-artifacts/ |
There was a problem hiding this comment.
just FYI the homepage link from pypi leads to https://github.com/aws/sagemaker-schema-inference-artifacts which isn't public.
There was a problem hiding this comment.
Our team doesn't own sagemaker-schema-inference-artifacts, it's maintained by the SageMaker Inference team. However, we need to create this conda-forge package because our package (sagemaker-serve) depends on it. The manager is aware of this PR.
| build: | ||
| number: 0 | ||
| noarch: python | ||
| script: ${{ PYTHON }} -m pip install "sagemaker_schema_inference_artifacts-${{ version }}-py3-none-any.whl" -vv --no-deps |
There was a problem hiding this comment.
It's recommended to build from a sdist instead of a wheel as pointed out in #32176 (comment)
There was a problem hiding this comment.
sagemaker_schema_inference_artifacts pypi only seems to have wheel in file downloads.
There was a problem hiding this comment.
Can you use the GitHub source instead?
There was a problem hiding this comment.
The github repo is private, so I think this is not possible? We don't own this package but need it as a dependency for sagemaker-serve.
There was a problem hiding this comment.
Isn't it this repo: https://github.com/aws/sagemaker-python-sdk/tree/v3.4.1 ? I can access it just fine. It sure makes it hard to figure out what version what is b/c every is bundled under the same version there!
There was a problem hiding this comment.
sagemaker-schema-inference-artifacts is from https://github.com/aws/sagemaker-schema-inference-artifacts, which is a private repo from a partner team
There was a problem hiding this comment.
@ocefpaf would be great if you could help merge this PR, or provide any other feedback for improvement. Thanks!
|
I confirm to be maintainer of these pacakges |
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
@conda-forge-admin, please rerender |
|
@conda-forge/help-python ready for review! |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).