Open
Conversation
baszalmstra
reviewed
Feb 10, 2026
Comment on lines
+237
to
+240
| for c in segment_components[last_num_idx + 1..].iter_mut() { | ||
| if let Some(id) = c.as_iden_mut() { | ||
| *id = "a".into(); | ||
| } |
Collaborator
There was a problem hiding this comment.
Should we not also only reset this for a, alpha, beta, b, rc`?
| .next_back(); | ||
| // Find the position of the last numeral so we only | ||
| // reset idens that appear after it. | ||
| let last_num_idx = segment_components |
Collaborator
There was a problem hiding this comment.
Can we keep the name last_numeral_component? We also have segments and I find this more confusin.
| /// appears before the bumped numeral. | ||
| #[rstest] | ||
| #[case("0.60b1", VersionBumpType::Last, "0.60b2")] | ||
| #[case("0.60b1", VersionBumpType::Segment(1), "0.60b2")] |
Collaborator
There was a problem hiding this comment.
This one surprised me, but makes sense I guess!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how we should bump in practice. Do we expect
60a1->60a2or61a1?Fixes #2041