Ksql 13066 - Catch original GroupIdNotfoundException #10711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
pragatiguptaaa
changed the title
pragatiguptaaa
changed the title
# Conflicts: # ksqldb-engine/src/test/java/io/confluent/ksql/integration/KafkaConsumerGroupClientTest.java
…uld be before 'org.apache.kafka.common.errors.RetriableException'.
…uld be before 'import org.apache.kafka.common.errors.GroupNotEmptyException;'.
There was a problem hiding this comment.
Pull Request Overview
This pull request ensures that the consumer group description functionality is tested by uncommenting an existing test and introduces explicit handling for non-existent consumer groups based on KIP-1043 in the consumer group client implementation.
- Uncomment the test case for describing a consumer group in KafkaConsumerGroupClientTest.
- Add a catch block for GroupIdNotFoundException in KafkaConsumerGroupClientImpl with debug logging and an empty summary return.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ksqldb-engine/src/test/java/io/confluent/ksql/integration/KafkaConsumerGroupClientTest.java | Uncomment test for describing consumer groups |
| ksqldb-engine/src/main/java/io/confluent/ksql/services/KafkaConsumerGroupClientImpl.java | Add exception handling for GroupIdNotFoundException with appropriate logging |
3 tasks
pragatiguptaaa
changed the title
VedarthConfluent
approved these changes
Apr 4, 2025
Member
VedarthConfluent
left a comment
VedarthConfluent
left a comment
There was a problem hiding this comment.
Makes sense as we want to retain existing behaviour. LGTM
pbadani
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context:
Following Kafka's KIP-1043, describing a non-existent consumer group now consistently throws GroupIdNotFoundException.
Treat this expected scenario as a group with zero consumers by returning an empty consumerGroupSummary. This logs the exception, encapsulates the exception handling, simplifying the caller's contract.
Another approach: #10727
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist