Migrate CRDs from enterprise-contract/enterprise-contract-controller#2680
Closed
robnester-rh wants to merge 5 commits intoconforma:mainfrom
Closed
Migrate CRDs from enterprise-contract/enterprise-contract-controller#2680robnester-rh wants to merge 5 commits intoconforma:mainfrom
enterprise-contract/enterprise-contract-controller#2680robnester-rh wants to merge 5 commits intoconforma:mainfrom
Conversation
This commit is the initial migration of the CRDs from `enterprise-contract/enterprise-contract-controller` to this repo. Assisted-by: claude-4-sonnet Ref: EC-1316 Signed-off-by: Rob Nester <rnester@redhat.com>
This commit updates the github workflows to integrate the migrated CRDs. Additionally, the makefile was updated as appropriate. Assisted-by: claude-4-sonnet Ref: EC-1316 Signed-off-by: Rob Nester <rnester@redhat.com>
This commit updates the version of go specified in the `schema/go.mod` and `tools/crd/go.mod` files from `1.23.6` to `1.24.4` to provide consistency across all go modules in the project. Ref: EC-1316 Signed-off-by: Rob Nester <rnester@redhat.com>
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This commit updates license headers where appropriate for merged CRD related files. Ref: EC-1316 Signed-off-by: Rob Nester <rnester@redhat.com>
This commit updates the crd-schema workflow. Ref: EC-1316 Signed-off-by: Rob Nester <rnester@redhat.com>
joejstuart
reviewed
Aug 6, 2025
| for f in $(git diff --exit-code --name-only); do | ||
| echo "::error file=$f,line=1,col=1,endColumn=1::File was modified in build" | ||
| done | ||
| git status --porcelain |
Contributor
There was a problem hiding this comment.
I see this replaces the existing check. Is that ok, and should we now run make all when this check is triggered?
joejstuart
reviewed
Aug 6, 2025
| @@ -0,0 +1,21 @@ | |||
| # Copyright The Conforma Contributors | |||
Contributor
There was a problem hiding this comment.
I think this file is missing some content. Here is the original.
$ cat kustomization.yaml
# This kustomization.yaml is not intended to be run by itself,
# since it depends on service name and namespace that are out of this kustomize package.
# It should be run by config/default
resources:
- bases/appstudio.redhat.com_enterprisecontractpolicies.yaml
- enterprisecontractpolicy_editor_role.yaml
- enterprisecontractpolicy_viewer_role.yaml
- openshift_console_example.yaml
#+kubebuilder:scaffold:crdkustomizeresource
patchesStrategicMerge:
# [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix.
# patches here are for enabling the conversion webhook for each CRD
#- patches/webhook_in_enterprisecontractpolicies.yaml
#+kubebuilder:scaffold:crdkustomizewebhookpatch
# the following config is for teaching kustomize how to do kustomization for CRDs.
configurations:
- kustomizeconfig.yaml
Contributor
Author
|
This is being closed as the underlying story has changed. The CRDs will be migrated to their own repository per team discussions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a first pass at migrating the CRDs from the
enterprise-contract/enterprise-contract-controllerrepository.