enable no-unused-param tekton-lint rule

[robnester-rh]

User description

This commit re-enables the no-unused-param tekton-lint rule which was previously disabled due to unused parameters in the tasks.

To satisfy the lint rule, the verify-conforma-konflux-vsa-ta task was updated to use the EXTRA_RULE_DATA parameter. A second --extra-rule-data flag was added so the parameter is used while preserving the existing pipeline_intention=release behavior.

The parameter description and documentation were updated to note that pipeline_intention=release is always included.

Ref: EC-1635

---

PR Type

Enhancement

---

Description

• Re-enable no-unused-param tekton-lint rule by fixing unused parameters

• Update verify-conforma-konflux-vsa-ta task to use EXTRA_RULE_DATA parameter

• Add second --extra-rule-data flag to preserve pipeline_intention=release behavior

• Update parameter documentation to clarify pipeline_intention=release inclusion

---

Diagram Walkthrough

flowchart LR
  A["Lint Rule Disabled"] -->|"Re-enable no-unused-param"| B["Lint Rule Enabled"]
  C["Unused EXTRA_RULE_DATA Parameter"] -->|"Add flag usage"| D["Parameter Utilized"]
  E["Incomplete Documentation"] -->|"Update descriptions"| F["Clear Documentation"]
  B --> G["Task Compliance"]
  D --> G
  F --> G

Loading

File Walkthrough

	Relevant files
Configuration changes	.tektonlintrc.yaml Enable no-unused-param lint rule                                                  .tektonlintrc.yaml Changed no-unused-param rule from off to error Removed outdated comment referencing EC-1371 and EC-1425 Rule now enforces detection of unused parameters in tasks +1/-5
Documentation	verify-conforma-vsa-release-ta.adoc Clarify EXTRA_RULE_DATA parameter documentation                    docs/modules/ROOT/pages/verify-conforma-vsa-release-ta.adoc Updated EXTRA_RULE_DATA parameter documentation Added note clarifying that pipeline_intention=release is always included Improves clarity on parameter behavior and default values +1/-1
Enhancement	verify-conforma-konflux-vsa-ta.yaml Use EXTRA_RULE_DATA parameter in task command                        tasks/verify-conforma-konflux-vsa-ta/0.1/verify-conforma-konflux-vsa-ta.yaml Updated EXTRA_RULE_DATA parameter description with clarification note Added second --extra-rule-data=$(params.EXTRA_RULE_DATA) flag to command Ensures EXTRA_RULE_DATA parameter is actually used in task execution Preserves existing pipeline_intention=release behavior with dual flags +2/-1

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
⚪	Policy input injection Description: The task now forwards the user-controlled $(params.EXTRA_RULE_DATA) into --extra-rule-data=..., which may allow a pipeline author or untrusted param source to influence policy inputs and potentially bypass or weaken policy checks by overriding/adding Rego variables. verify-conforma-konflux-vsa-ta.yaml [340-341] Referred Code - "--extra-rule-data=pipeline_intention=release" - "--extra-rule-data=$(params.EXTRA_RULE_DATA)"
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Combine default and extra rule data Set the default value of the EXTRA_RULE_DATA parameter to pipeline_intention=release and remove the hardcoded --extra-rule-data flag to avoid argument overriding. tasks/verify-conforma-konflux-vsa-ta/0.1/verify-conforma-konflux-vsa-ta.yaml [128-133] - name: EXTRA_RULE_DATA type: string description: > Merge additional Rego variables into the policy data. Syntax: key=val,key2=val2. Note: pipeline_intention=release is always included. - default: "" + default: "pipeline_intention=release" +... + - "--extra-rule-data=$(params.EXTRA_RULE_DATA)" [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 9 __ Why: This suggestion correctly identifies a critical bug where pipeline_intention=release could be overridden, and proposes a simple, elegant fix by changing the parameter's default value.	High
More

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
acceptance	55.35% <ø> (-0.01%)	⬇️
generative	18.59% <ø> (ø)
integration	27.61% <ø> (ø)
unit	68.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[robnester-rh]

This merge is going to be dependent on a few other MRs/PRs for EC-1425, I'll merge this at the appropriate time. Currently that is likely to be on or around Feb 9.