Fix copy/paste including spurious newlines and whitespace#65
Open
nindanaoto wants to merge 1 commit intoconnectbot:mainfrom
Open
Fix copy/paste including spurious newlines and whitespace#65nindanaoto wants to merge 1 commit intoconnectbot:mainfrom
nindanaoto wants to merge 1 commit intoconnectbot:mainfrom
Conversation
When copying text that spans multiple terminal lines, the selection logic would insert newlines at every visual line boundary, even for lines that wrapped due to terminal width (soft wraps). This caused long commands to break when pasted back. Changes: - Add softWrapped field to TerminalLine to track soft vs hard line breaks - Expose libvterm's continuation flag via getLineContinuation() JNI method - Pass softWrapped status when pushing lines to scrollback - Update SelectionManager to only insert newlines for hard breaks - Trim trailing whitespace from each line when copying (terminal lines are padded with spaces to fill the terminal width) Fixes connectbot/connectbot#1555 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nindanaoto
force-pushed
the
newline_handling
branch
from
d6ea793 to
378fe2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes connectbot/connectbot#1555
When copying text that spans multiple terminal lines, the selection logic would insert newlines at every visual line boundary, even for lines that wrapped due to terminal width (soft wraps). This caused long commands to break when pasted back. This PR also removes trailing whitespace from each line to ensure the copy matches the original.
Changes:
🤖 Generated with Claude Code