Adding weightHP query option to functions#29
Adding weightHP query option to functions#29umayaml wants to merge 2 commits intoconnectome-neuprint:masterfrom umayaml:master
Conversation
…paths. If set to true, will use weightHP value in the Neuron to Neuron relationship instead of weight value.
|
Thinking about this a little more... Right now, the neuprint datamodel only provides Also, as a side note, I'm wondering if we should make this new argument a keyword-only argument, just to avoid breaking existing code that calls it using the current argument order. On a related point, apparently And on a related point to that: I think |
|
I've edited the PR description above to add a TODO checklist. Thanks again for posting this draft PR immediately for the first two functions (as we discussed), rather than implementing everything in one go. This gives us a chance to nail down some API details before you change all of the relevant functions. |
|
@umayaml I reorganized the contents of |
Adding
weightHPquery option tofetch_shortest_pathsandfetch_simple_connections, etc.See #25
TODO
The following functions will all need to be updated to support a high-precision option.
fetch_adjacencies()fetch_traced_adjacencies()fetch_simple_connections()fetch_common_connectivity()roiparameter, too.fetch_shortest_paths()fetch_output_completeness()fetch_downstream_orphan_tasks()Updating the following functions will require a more significant change to the API, since they don't use
weightHP. They inspect synapses individually, but I think it would be best to aim for conceptual consistency with the above functions if possible. Perhaps these updates should be deferred for now, and implemented in a separate pull request.fetch_synapse_connections()fetch_connection_mitochondria()Documentation updates:
docs/source/changelog.rstdocs/source/faq.rst?