fix: resolve objectStorage and instance cancel API errors (fixes #47)#48
Open
zoonderkins wants to merge 1 commit intocontabo:mainfrom
Open
fix: resolve objectStorage and instance cancel API errors (fixes #47)#48zoonderkins wants to merge 1 commit intocontabo:mainfrom
zoonderkins wants to merge 1 commit intocontabo:mainfrom
Conversation
…abo#47) This commit fixes three critical issues that prevented the cancel commands from working: 1. Missing API Request Body: Both objectStorage and instance cancel commands were missing the required CancelRequest body parameter, causing API errors. - Added CancelObjectStorageRequest for objectStorage cancel - Added CancelInstanceRequest for instance cancel 2. Variable Name Typo: Fixed typo in objectStorage cancel command - Changed cancelbjectStorageId to cancelObjectStorageId (missing O) - Updated in cancel.go and vars.go 3. Nil Pointer Dereference: Fixed panic in error handler when httpResp is nil - Added nil check before accessing httpResp.Body in handleErrors() - Prevents crash on network errors or connection failures Changes: - cmd/objectStorage/cancel.go: Add request body and fix variable name - cmd/objectStorage/vars.go: Fix variable name typo - cmd/instances/cancel.go: Add request body - cmd/util/handleErrors.go: Add nil pointer check Tested with: cntb cancel objectStorage 4c4bd92c-0654-4848-ab87-3c04ec0e27dd Result: Successfully cancelled with cancelDate 2025-10-24 Fixes contabo#47
moelkenzi
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the critical bug reported in #47 where the
cntb cancel objectStoragecommand was failing with a panic error.Problem
When attempting to cancel an object storage using:
The command failed with:
And after fixing the panic, it failed with:
Root Causes
This PR addresses three critical issues:
1. Missing API Request Body
Both
objectStorage cancelandinstance cancelcommands were missing the required request body parameter:CancelObjectStorageRequestorCancelInstanceRequestobjectCancelObjectStorageRequestandCancelInstanceRequestinitialization2. Variable Name Typo
The objectStorage cancel command had a typo in the variable name:
cancelbjectStorageId(missing the letter 'O')cancelObjectStorageIdin bothcancel.goandvars.go3. Nil Pointer Dereference
The error handler was accessing
httpResp.Bodywithout checking ifhttpRespis nil:httpRespcan benilhttpResp.BodyinhandleErrors()Changes
cmd/objectStorage/cancel.go: Add request body initialization and fix variable namecmd/objectStorage/vars.go: Fix variable name typocmd/instances/cancel.go: Add request body initializationcmd/util/handleErrors.go: Add nil pointer check for httpRespTesting
✅ Tested successfully with:
Result:
✅ Compilation successful with no errors
Impact
Checklist
Fixes #47
Pull Request opened by Augment Code with guidance from the PR author