Use relative path for vm state directory#90
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Feb 3, 2026
Merged
Conversation
dmcgowan
force-pushed
the
fix-vm-socket-path
branch
from
597497f to
e78ebbc
Compare
There was a problem hiding this comment.
Pull request overview
This PR changes the vm state directory from being bundle-relative to current-working-directory-relative to prevent socket path length issues on macOS where path resolution can differ (e.g., /var vs /private/var).
Changes:
- Modified vm state directory creation to use
filepath.Abs("vm")instead offilepath.Join(r.Bundle, "vm") - Added error handling for the absolute path resolution
- Added a comment explaining the rationale for the change
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prevents socket paths becoming too long when the resolved current working directory differs from the given bundle path, for example current working directory resolving to `/private/var/...` but the bundle directory reported as `/var/...`. The vm state directory does not need to be associated with a specific bundle and the working directory assigned to the shim is sufficient as the parent for the vm state directory. Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
fix-vm-socket-path
branch
from
e78ebbc to
e1eaba4
Compare
estesp
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents socket paths becoming too long when the resolved current working directory differs from the given bundle path, for example current working directory resolving to
/private/var/...but the bundle directory reported as/var/.... The vm state directory does not need to be associated with a specific bundle and the working directory assigned to the shim is sufficient as the parent for the vm state directory.