Draft
Conversation
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Mossaka
reviewed
Mar 6, 2025
| } | ||
|
|
||
| #[cfg_attr(feature = "tracing", tracing::instrument(level = "Info"))] | ||
| fn shim_main_inner<'a, I>( |
Member
There was a problem hiding this comment.
I tried a similar refactoring before, but I realized that if there is only one shim_main function, then it's own trace will not be exported to the trace collector becuase this function initializes the opentelemetry infras. This is the main reason I splitted it to shim_main and shim_main_inner so that one can initialize a otel runtime and another one can export it's function tracing to the collector.
I am assuming with your refactoring we will not be able to see shim_main trace anymore.
Collaborator
Author
There was a problem hiding this comment.
oh, good catch, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.