ci: fix test (check) flake caused by older md2man#1987
Open
kolyshkin wants to merge 2 commits intocontainers:mainfrom
Open
ci: fix test (check) flake caused by older md2man#1987kolyshkin wants to merge 2 commits intocontainers:mainfrom
kolyshkin wants to merge 2 commits intocontainers:mainfrom
Conversation
Sometimes (but not always) make wants to re-generate the man pages in CI while the sources haven't changed in fact. Sometimes the man pages are actually changed, so CI needs to check if the generated man pages is updated accordingly. Either way, it fails because Ubuntu has an older version of go-md2man. This is not easy to fix in a decent manner but the not-so-decent is to install the latest md2man from source, this is what this patch does. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
It allows the test to exit with an error in case there are changes. The command right after should do the same but maybe it has some extra checks, so I'm not removing it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Collaborator
Author
|
A recent example of a flake: https://github.com/containers/crun/actions/runs/21749003949/job/62741950113 |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
TMT tests failed. @containers/packit-build please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes (but not always) make wants to re-generate the man pages
in CI while the sources haven't changed in fact. Sometimes the man
pages are actually changed, so CI needs to check if the generated
man pages is updated accordingly.
Either way, it fails because Ubuntu has an older version of go-md2man.
This is not easy to fix in a decent manner but the not-so-decent is
to install the latest md2man from source, this is what this patch does.
(the decent way would be to run man page generation in a fedora container, I guess, but it seems like too much)