cgroup-systemd: do not use errno after success

[eriksjolund]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @eriksjolund, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a subtle bug in error handling within the cgroup-systemd component. It prevents the misuse of the errno global variable by ensuring it is not referenced in error reporting paths that do not stem from a system call failure, thereby improving the accuracy of error messages.

Highlights

• Error Handling: Corrected an issue where the 'errno' global variable was being used after a successful operation, which could lead to misleading error messages.
• cgroup-systemd: Specifically, in the 'append_systemd_annotation' function, the error code passed to 'crun_make_error' is now explicitly set to 0 instead of 'errno' when an "unknown type" error occurs, ensuring 'errno' is only consulted when an actual system error has happened.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/libcrun/cgroup-systemd.c
  • Fixed incorrect usage of 'errno' in 'append_systemd_annotation' function.
  • Changed error code passed to 'crun_make_error' from 'errno' to 0 for "unknown type" errors.

Activity

• The author, eriksjolund, opened this pull request to address a specific error handling bug.
• The pull request title clearly states the intent: 'cgroup-systemd: do not use errno after success'.
• The change involves a single line modification in src/libcrun/cgroup-systemd.c.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue where a stale errno value could be used when reporting an error for an unknown type in append_systemd_annotation. The error being reported is a logical one within the application (an unknown type was encountered during parsing), not a system error, so errno is not relevant. By changing errno to 0 in the call to crun_make_error, the fix prevents potentially misleading error messages from being generated. The change is correct and improves the robustness of error handling.

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.