vsock/tsi: use EDGE_TRIGGERED on EventSet::OUT#531
Open
slp wants to merge 2 commits intocontainers:mainfrom
Open
vsock/tsi: use EDGE_TRIGGERED on EventSet::OUT#531slp wants to merge 2 commits intocontainers:mainfrom
slp wants to merge 2 commits intocontainers:mainfrom
Conversation
When we're waiting on ProxyStatus::Connecting, we set EventSet::OUT to be informed when the socket has connected. Use EDGE_TRIGGERED along with it so the event is generated just once. Signed-off-by: Sergio Lopez <slp@redhat.com>
It was useful to have this as an error while we were checking for correctness, but now it just confuses users into thinking there's an actual problem. Tone it down from error to debug. Signed-off-by: Sergio Lopez <slp@redhat.com>
slp
requested review from
MatiasVara,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we're waiting on ProxyStatus::Connecting, we set EventSet::OUT to be informed when the socket has connected. Use EDGE_TRIGGERED along with it so the event is generated just once.
Fixes bogus errors on #526