-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: limited MCP App support #10132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RomneyDa
wants to merge
5
commits into
main
Choose a base branch
from
dallin/mcp-apps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Review Complete Code Review Summary |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 17 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="gui/src/pages/gui/ToolCallDiv/MCPAppRenderer.tsx">
<violation number="1" location="gui/src/pages/gui/ToolCallDiv/MCPAppRenderer.tsx:129">
P1: The iframe renders MCP-provided HTML via srcDoc and enables "allow-same-origin" with scripts, which removes the opaque origin normally provided by sandboxing. This lets untrusted MCP HTML run scripts with same-origin access to the parent webview (window.parent/DOM), defeating isolation. Unless same-origin access is strictly required, drop allow-same-origin or gate it to trusted content.</violation>
<violation number="2" location="gui/src/pages/gui/ToolCallDiv/MCPAppRenderer.tsx:223">
P2: Successful tool calls are always marked as errors because `isError` is hardcoded to `true` after the success path.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note, most new lines are in package lock. this is a 400 line PR
Adds MCP Apps support for continue
_metafor ui info, and after tool call reads UI resource and injects in iframemcp-uicomponents within VS Code (or at least I couldn't figure it out) so I just made a fresh iframeExample MCP configs to test:
Continue Tasks:▶️ 1 queued — View all
Summary by cubic
Adds MCP App support so MCP tools can render interactive UIs inside Continue. The UI is loaded from the tool’s MCP UI resource and shown in a secure iframe with a postMessage bridge.
New Features
Dependencies
Written for commit ab680d0. Summary will update on new commits.