SymfonyValidator errors with typed properties

[martenb]

Ok, i switched to typed properties and found some bugs in SymfonyValidator,, i am not sure, how to fix it, maybe you will know?

	#[Assert\NotNull]
	#[Assert\Type(type: 'integer')]
	public $typedId;

when you send ['typedId' => 'sss'] the validator throws typeId is not integer, but

	#[Assert\NotNull]
	#[Assert\Type(type: 'integer')]
	public int $typedId;

throws typedId cannot be null...

This is real problem in nullable properties

	#[Assert\Type(type: 'integer')]
	public ?int $typedId = null;

when you send ['typedId' => 'sss'], it will pass without any errors...

[f3l1x]

Will take a 👀

[f3l1x]

At this time, implementation looks like this:

apitte/src/Core/Mapping/Request/BasicEntity.php

Lines 45 to 72 in 816aa4f

	public function factory(array $data): self
	{
	$inst = new static();
	// Fill properties with real data
	$properties = $inst->getRequestProperties();
	foreach ($properties as $property) {
	if (!array_key_exists($property['name'], $data)) {
	continue;
	}
	$value = $data[$property['name']];
	// Normalize & convert value (only not null values)
	if ($value !== null) {
	$value = $this->normalize($property['name'], $value);
	}
	// Fill single property
	try {
	$inst->{$property['name']} = $value;
	} catch (TypeError) {
	// do nothing, entity will be invalid if something is missing and ValidationException will be thrown
	}
	}
	return $inst;
	}

It means, if you have typed property int $typedId and try to assign string to it, PHP will throws error, but there is a try/catch.

apitte/src/Core/Mapping/Request/BasicEntity.php

Lines 64 to 68 in 816aa4f

	try {
	$inst->{$property['name']} = $value;
	} catch (TypeError) {
	// do nothing, entity will be invalid if something is missing and ValidationException will be thrown
	}

It's not the best implementation I know. Better implementation would be read the validations (NotNull, TypedInt, etc.) and validate input as array, but it's huge BC at this time.

[f3l1x]

I've added some more tests for the future 33ec0d4