Fix Grafana dashboard for AsyncAPIs#2444
Open
jackmpcollins wants to merge 2 commits intocortexlabs:masterfrom
Open
Fix Grafana dashboard for AsyncAPIs#2444jackmpcollins wants to merge 2 commits intocortexlabs:masterfrom
jackmpcollins wants to merge 2 commits intocortexlabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
async_queue_length->async_queuedso that the list of api_names is populated (currently empty)=~withapi_namewhere missing to enable displaying multiple AsyncAPIs on a panelapi_namein the legendTesting
I have made the corresponding updates manually through the Grafana UI for our deployed Cortex cluster. AsyncAPIs now list in the "Cortex / AsyncAPI" dashboard and the dashboard works when multiple AsyncAPIs are selected.
checklist:
make testandmake lintsummary.md(view in gitbook after merging)