Use Go workspace for path management#13
Open
LaurentGoderre wants to merge 1 commit intocouchbase:masterfrom
Open
Use Go workspace for path management#13LaurentGoderre wants to merge 1 commit intocouchbase:masterfrom
LaurentGoderre wants to merge 1 commit intocouchbase:masterfrom
Conversation
abhinavdangeti
added a commit
to abhinavdangeti/cbft
that referenced
this pull request
Apr 8, 2024
* 381a839b Abhi Dangeti | MB-60400: Upgrade to zapx/v16@v16.0.2 (#1972)
* c27bdd0 Rahul Rampure | MB-60400: Reduce Garbage generated (#208)
* 0b5d67d Rahul Rampure | MB-60400: Reduce Garbage (couchbase#13)
* d78f43e9 Rahul Rampure | MB-60400: Reduce garbage generated (#1970)
Change-Id: I9eb31d0ad0ab5682327dc846accb42c18f7faa8c
Reviewed-on: https://review.couchbase.org/c/cbft/+/204688
Well-Formed: Restriction Checker
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Abhi Dangeti <abhinav@couchbase.com>
Tested-by: Abhi Dangeti <abhinav@couchbase.com>
LaurentGoderre
force-pushed
the
use-go-work
branch
from
71a951f to
8c2a7dd
Compare
Author
|
@abhinavdangeti could I get a review for this? |
Member
|
@LaurentGoderre couchbase/cbft is meant to work within the couchbase eco system, this code is necessary for our builds to work and maintainance. If this is something you want to drop - I would recommend forking this project and making the changes you wish. |
Author
|
@abhinavdangeti The snippet I have include in the description using Go workspaces is the recommended way to do this specific thing the project is doing. It gives the same benefits while generating proper dependency metadata in the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This structure is creating some weird SBOMs. By using the following
go.workfile, the package naming is preservedhttps://go.dev/doc/tutorial/workspaces