[4.0.3 backport] CBG-5118: Support request-provided oldDoc values in Sync Function Dry-Run#8024
Merged
gregns1 merged 1 commit intorelease/4.0.3from Jan 23, 2026
Merged
[4.0.3 backport] CBG-5118: Support request-provided oldDoc values in Sync Function Dry-Run#8024gregns1 merged 1 commit intorelease/4.0.3from
gregns1 merged 1 commit intorelease/4.0.3from
Conversation
…ry-Run (#8019) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Redocly previews |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports support for request-provided oldDoc values in the Sync Function Dry-Run API to version 4.0.3. The change allows users to specify an inline oldDoc body when testing sync functions, expanding the API's flexibility beyond the existing behavior of fetching oldDoc from the bucket via doc_id.
Changes:
- Adds support for inline
oldDocparameter in the dry-run API request payload - Updates API documentation to reflect the new
oldDocparameter and valid parameter combinations - Adds validation to prevent conflicting usage of
doc_idwith inlineoldDoc
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rest/diagnostic_doc_api.go | Implements oldDoc support in the dry-run handler, adds validation logic, and renames function/constant for consistency |
| rest/diagnostic_doc_api_test.go | Adds test coverage for inline oldDoc usage and updates existing tests to use renamed constant |
| docs/api/paths/diagnostic/keyspace-sync.yaml | Updates OpenAPI specification with oldDoc parameter documentation and behavior table |
| db/crud.go | Renames SyncFnDryrun to SyncFnDryRun and fixes oldDoc body handling to use BodyBytes() |
gregns1
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean cherry-pick of #8019 for 4.0.3
Integration Tests