Use the lineno attribute of TextNode.token if TextNode.position is unavailable#85
Open
TaylorSMarks wants to merge 1 commit intocoveragepy:mainfrom
Open
Use the lineno attribute of TextNode.token if TextNode.position is unavailable#85TaylorSMarks wants to merge 1 commit intocoveragepy:mainfrom
TaylorSMarks wants to merge 1 commit intocoveragepy:mainfrom
Conversation
… but not a position. Unsure whether it should be considered a bug within Django or within django_coverage_plugin (or my project), but either way, this fixed it for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixed an issue I had in one of my files. I have no idea whether the TextNode was lacking a position because of a bug within Django or in my code, or if this was to be expected and Django_Coverage_Plugin needs to handle this.
I don't have a test case that I can publicly share, but I can say that without my change, it wasn't properly seeing that the file was being used, and with this change, it worked fine.