fix(daemon): exit process when cluster completes #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release dev to main --------- Co-authored-by: Eivind Meyer <eiv.meyer@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Eivind Meyer <eivind.meyer@ksat.no> Co-authored-by: Michael Eichelbeck <141341133+mkceichelbeck@users.noreply.github.com> Co-authored-by: Michael Eichelbeck <michael.eichelbeck.ext@wtsde.onmicrosoft.de>
CLUSTER_COMPLETE triggers orchestrator.stop() which sets state to 'stopped', but no SIGTERM was sent to trigger the cleanup handlers. Added polling in setupDaemonCleanup to detect state change and exit. Fixes zombie zeroshot processes in heroshot runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Zombie zeroshot processes remained after heroshot shipped PRs, blocking new agent spawns.
Root Cause
When CLUSTER_COMPLETE triggers
orchestrator.stop(), the cluster state changes to 'stopped' but no SIGTERM is sent. The cleanup handlers registered viaprocess.on('SIGTERM')are never triggered.Fix
Added polling in
setupDaemonCleanup()to detect when cluster state changes to 'stopped' or 'completed', then exit the process.Testing
The fix was triggered by a heroshot run where 3 zombie processes from already-shipped items (#1159, #1168) were blocking new spawns.