Conversation
want to resole: WARN 1 deprecated subdependencies found: node-domexception@1.0.0
|
|
WalkthroughUpdated dependency versions in packages/coze-js/package.json: agora-extension-ai-denoiser to ^1.1.0 and agora-rtc-sdk-ng to 4.24.0. No other changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/coze-js/package.json(1 hunks)
Comment on lines
+63
to
+64
| "agora-extension-ai-denoiser": "^1.1.0", | ||
| "agora-rtc-sdk-ng": "4.24.0", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Bump looks good; verify the deprecation is actually gone and consider loosening the pin.
- The upgrades to
agora-extension-ai-denoiser@^1.1.0andagora-rtc-sdk-ng@4.24.0look fine. - Please confirm the original warning about
node-domexception@1.0.0is eliminated across the workspace lockfile. If it persists, add an override fornode-domexceptionto^2.0.1. - Optional: for a library, consider
^4.24.0instead of an exact4.24.0to avoid over-constraining consumers (unless you intentionally want a hard pin for reproducibility). Your existingoverrideskeeps the extension aligned anyway.
Apply if the warning persists:
"overrides": {
"agora-extension-ai-denoiser": {
"agora-rtc-sdk-ng": "$agora-rtc-sdk-ng"
- }
+ },
+ "node-domexception": "^2.0.1"
}Run to verify:
🏁 Script executed:
#!/bin/bash
# 1) Check if deprecated version still exists
rg -n "node-domexception@1\.0\.0" pnpm-lock.yaml || true
# 2) Find why it's pulled in
pnpm why node-domexception || true
# 3) Ensure only one Agora SDK version is resolved
rg -n "^ {2}agora-rtc-sdk-ng@" pnpm-lock.yaml -n -C0 || trueLength of output: 258
🏁 Script executed:
#!/bin/bash
# List top-level files to locate lockfiles
find . -maxdepth 1 -type f -printf '%f\n'
# Search for common lockfiles across the repo
find . -type f \( -iname "yarn.lock" -o -iname "package-lock.json" -o -iname "pnpm-lock.yaml" \) -maxdepth 3Length of output: 375
🏁 Script executed:
#!/bin/bash
# Display the beginning of rush.json to locate lockfile configuration
sed -n '1,200p' rush.jsonLength of output: 11146
🏁 Script executed:
#!/usr/bin/env bash
# Search for deprecated node-domexception across all workspace lockfiles
find . -type f \( -iname "pnpm-lock.yaml" -o -iname "yarn.lock" -o -iname "package-lock.json" \) \
-exec echo "Scanning {}" \; \
-exec rg -n "node-domexception@" {} \; || trueLength of output: 596
🏁 Script executed:
#!/usr/bin/env bash
# Find any pnpm override configuration or pnpmfile
find . -type f \( -iname "pnpmfile.js" -o -iname "package.json" \) -maxdepth 4 \
-exec grep -Hn '"overrides"' {} \; || trueLength of output: 169
Add override for node-domexception
- Lockfiles still resolve
node-domexception@1.0.0; underoverridesinpackages/coze-js/package.jsonappend:"overrides": { "agora-extension-ai-denoiser": { "agora-rtc-sdk-ng": "$agora-rtc-sdk-ng" -
}
-
}, -
}
"node-domexception": "^2.0.1"then run `rush update` or `pnpm install` to confirm `node-domexception@^2.0.1` is now resolved.
- Optional: loosen the pin on
"agora-rtc-sdk-ng": "4.24.0"to"^4.24.0"to avoid over-constraining consumers.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "agora-extension-ai-denoiser": "^1.1.0", | |
| "agora-rtc-sdk-ng": "4.24.0", | |
| // In packages/coze-js/package.json, update (or create) the "overrides" section as follows: | |
| { | |
| // … other top-level fields … | |
| "overrides": { | |
| "agora-extension-ai-denoiser": { | |
| "agora-rtc-sdk-ng": "$agora-rtc-sdk-ng" | |
| }, | |
| "node-domexception": "^2.0.1" | |
| } | |
| // … the rest of the file … | |
| } |
🤖 Prompt for AI Agents
In packages/coze-js/package.json around lines 63 to 64, the dependency graph
still resolves node-domexception@1.0.0; add an overrides section to force
node-domexception@^2.0.1 (e.g. append an "overrides": {"node-domexception":
"^2.0.1"} entry at the root of the package.json) and then run rush update or
pnpm install to verify the lockfile now resolves node-domexception@^2.0.1;
optionally loosen the agora-rtc-sdk-ng pin from "4.24.0" to "^4.24.0" to avoid
over-constraining consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
want to resole:
WARN 1 deprecated subdependencies found: node-domexception@1.0.0
Summary by CodeRabbit