Conversation
…with expt_turn_result_filter_local table (LogID: 20250930145642010091110134764A37C) Co-Authored-By: Coda <coda@bytedance.com>
…ame instead of adding new interface (LogID: 20250930145642010091110134764A37C) Co-Authored-By: Coda <coda@bytedance.com>
…ocal table creation (LogID: 20250930145642010091110134764A37C) Co-Authored-By: Coda <coda@bytedance.com>
…_result_filter_local (LogID: 20250930145642010091110134764A37C) Co-Authored-By: Coda <coda@bytedance.com>
d6c85d3 to
5226985
Compare
5226985 to
61f94da
Compare
CozeLoop
reviewed
Nov 18, 2025
Collaborator
CozeLoop
left a comment
There was a problem hiding this comment.
Summary: Posted inline review comments focusing on correctness and deployment consistency. One [MUST FIX] issue (SQL args mismatch when itemIDs is empty) and several [SHOULD FIX]/[SUGGESTION] items for performance/config clarity and Helm values consistency.
backend/modules/evaluation/infra/repo/experiment/ck/expt_turn_result_filter.go
Show resolved
Hide resolved
backend/modules/evaluation/infra/repo/experiment/ck/expt_turn_result_filter.go
Show resolved
Hide resolved
backend/modules/evaluation/infra/repo/experiment/ck/expt_turn_result_filter.go
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 68.47% 68.52% +0.04%
==========================================
Files 569 569
Lines 51739 51676 -63
==========================================
- Hits 35430 35410 -20
+ Misses 13563 13536 -27
+ Partials 2746 2730 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
lsy357
reviewed
Nov 19, 2025
backend/modules/evaluation/infra/repo/experiment/ck/convertor/expt_turn_result_filter.go
Show resolved
Hide resolved
HearyShen
approved these changes
Nov 19, 2025
lsy357
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: