Conversation
This moves async fn out of trait declaration to allow using `Client` instance passed by reference. This avoids cloning the `Client` instance which consequently created a new connection to the same domain.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 97.58% 97.53% -0.05%
==========================================
Files 14 14
Lines 3430 3406 -24
==========================================
- Hits 3347 3322 -25
- Misses 83 84 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I think the proper way would be to use tokio's async channels, but we're not doing a massive amount of REST API work here. |
Collaborator
Author
|
The lines missing coverage were uncovered before this. Coverage went down slightly because the reformatted source has fewer total lines. |
also ensure log messages are flushed to stdout (while mutex is locked)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves async fn out of trait declaration to allow using
Clientinstance passed by reference.This avoids cloning the
Clientinstance which can be costly to CPU and memory.