Add tests for ProperContains and ProperIn#48
Open
antvaset wants to merge 1 commit intocqframework:mainfrom
Open
Add tests for ProperContains and ProperIn#48antvaset wants to merge 1 commit intocqframework:mainfrom
antvaset wants to merge 1 commit intocqframework:mainfrom
Conversation
This was referenced Aug 12, 2024
raleigh-g-thompson
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more tests for ProperContains and ProperIn operators to cover more edge cases for the list overload.
Adjusting 4 existing tests to make it clear and make sure that ProperContainsNullRightFalse and ProperContainsNullRightTrue compile to ProperContains(List, T) and that ProperInNullRightFalse and ProperInNullRightTrue compile to ProperIn(T, List), matching the test name/group. Without null as String, the args could be resolved as List, List and compile to ProperIncludes(List, List) and ProperIncludedIn(List, List).
Unfortunately, the original PR (#40) was closed automatically and cannot be reopened, so I have to open this new one.
Note that there's also an active thread under cqframework/clinical_quality_language#1394.